Skip to content

Add CUDA 12.8 torchaudio and torchvision x86 builds#6244

Merged
atalman merged 3 commits intopytorch:mainfrom
tinglvv:cu128-domain-builds
Feb 3, 2025
Merged

Add CUDA 12.8 torchaudio and torchvision x86 builds#6244
atalman merged 3 commits intopytorch:mainfrom
tinglvv:cu128-domain-builds

Conversation

@tinglvv
Copy link
Copy Markdown
Contributor

@tinglvv tinglvv commented Feb 3, 2025

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 3, 2025

@tinglvv is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm labels Feb 3, 2025
@tinglvv
Copy link
Copy Markdown
Contributor Author

tinglvv commented Feb 3, 2025

Deprecating CUDA_CUDDN_VERSIONS dict as I don't see it called elsewhere (the name also had a typo in it)

@nWEIdia
Copy link
Copy Markdown
Contributor

nWEIdia commented Feb 3, 2025

Deprecating CUDA_CUDDN_VERSIONS dict as I don't see it called elsewhere (the name also had a typo in it)

Referenced by: https://github.com/pytorch/test-infra/blob/main/tools/scripts/generate_docker_release_matrix.py#L48

@tinglvv
Copy link
Copy Markdown
Contributor Author

tinglvv commented Feb 3, 2025

Deprecating CUDA_CUDDN_VERSIONS dict as I don't see it called elsewhere (the name also had a typo in it)

Referenced by: https://github.com/pytorch/test-infra/blob/main/tools/scripts/generate_docker_release_matrix.py#L48

Thanks! Did a global search and found it. Let me add it back.

@zxiiro
Copy link
Copy Markdown
Collaborator

zxiiro commented Feb 3, 2025

@atalman

What's the policy on how many versions of CUDA we need to test for?

(11.8, 12.4, 12.6, and now 12.8 would be 4 versions, is there a process where we go back and remove some of the tests?)

Same with Python do we really need to test on 5 versions of Python 3.9, 3.10, 3.11, 3.12, and 3.13?

@zxiiro
Copy link
Copy Markdown
Collaborator

zxiiro commented Feb 3, 2025

@atalman

What's the policy on how many versions of CUDA we need to test for?

(11.8, 12.4, 12.6, and now 12.8 would be 4 versions, is there a process where we go back and remove some of the tests?)

Same with Python do we really need to test on 5 versions of Python 3.9, 3.10, 3.11, 3.12, and 3.13?

We discussed this on the CI Sync meeting today and @atalman shared with us a link (https://github.com/pytorch/rfcs/blob/master/RFC-0038-cpython-support.md). Looks like we support every released version of Python as long as its not EOL.

For CUDA 3 versions are supported so 12.4 will be removed once 12.8 is confirmed working. This answers my questions. Thanks!

@atalman
Copy link
Copy Markdown
Contributor

atalman commented Feb 3, 2025

Hi @zxiiro For each cuda update we have RFC issue: pytorch/pytorch#145544 where release matrix is discussed.

Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 3660993 into pytorch:main Feb 3, 2025
@tinglvv
Copy link
Copy Markdown
Contributor Author

tinglvv commented Feb 3, 2025

Just noticed we should skip only the Windows build for 12.8, fix in #6252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants