[Nova] Honor with-cuda flag when building aarch64 wheel#6112
Open
huydhn wants to merge 5 commits intopytorch:mainfrom
Open
[Nova] Honor with-cuda flag when building aarch64 wheel#6112huydhn wants to merge 5 commits intopytorch:mainfrom
huydhn wants to merge 5 commits intopytorch:mainfrom
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
huydhn
commented
Dec 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discover this issue when debugging FBGEMM aarch64 build in which the build picks up both CPU and CUDA builds even then
with-cudais set to false there pytorch/FBGEMM#3528 (comment).Another note is that I don't think we have an arm runner with GPU at the moment (correct me if I'm wrong). So, Nova CUDA aarch64 build would never be able to run smoke test because there is no GPU. We would probably need to:
cc @q10