Skip to content

Handle ClickHouse JSONEachRow format#5947

Merged
huydhn merged 1 commit intomainfrom
handle-benchmark-results-jsoneachrow
Nov 20, 2024
Merged

Handle ClickHouse JSONEachRow format#5947
huydhn merged 1 commit intomainfrom
handle-benchmark-results-jsoneachrow

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Nov 20, 2024

This is the format used by ClickHouse, so it's useful to support this too in addition to a valid JSON list of benchmark records.

Testing

@huydhn huydhn requested review from a team, clee2000 and malfet November 20, 2024 06:26
@vercel
Copy link
Copy Markdown

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Nov 20, 2024 6:26am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
Copy link
Copy Markdown
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn huydhn merged commit 236d9a1 into main Nov 20, 2024
@huydhn huydhn deleted the handle-benchmark-results-jsoneachrow branch November 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants