Windows AMI Pin vs 2022 to older msvc release#5337
Merged
atalman merged 2 commits intopytorch:mainfrom Jun 13, 2024
Merged
Conversation
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
malfet
approved these changes
Jun 13, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
Would be nice to add a reference to VC++ version CUDA supports
Also, why it affects only vision but not the core? Should we perhaps update something there?
Contributor
Author
|
Very detailed info on this comment: pytorch/vision#8492 (comment) Good question why it does not affect core. Do we reinstall for core ? |
ZainRizvi
approved these changes
Jun 13, 2024
| # Pin to older vs_buildtools version for cuda 11.8 and 12.1 builds | ||
| # see issue: nerfstudio-project/nerfstudio#3157 | ||
| if ( ${env:VS_YEAR} -eq "2022" ) { | ||
| $VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.8/vs_buildtools.exe" |
Contributor
There was a problem hiding this comment.
Does the casing of BuildTools.exe need to change between the two links? (line 8 and line 13)
Contributor
Author
There was a problem hiding this comment.
Line 8 is still needed for MSVC 2019
Co-authored-by: Zain Rizvi <ZainRizvi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pytorch/vision#8492 for reference
Link taken from here: https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history#evergreen-bootstrappers