Provide additional info about unstable and infra flaky jobs#5156
Merged
huydhn merged 6 commits intopytorch:mainfrom May 2, 2024
Merged
Provide additional info about unstable and infra flaky jobs#5156huydhn merged 6 commits intopytorch:mainfrom
huydhn merged 6 commits intopytorch:mainfrom
Conversation
|
@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZainRizvi
approved these changes
May 1, 2024
Comment on lines
+68
to
83
| export function isUnstableJob( | ||
| job: JobData, | ||
| unstableIssues?: IssueData[] | ||
| ): { unstable: boolean; issues: IssueData[] } { | ||
| // The name has the unstable keywork, the job is unstable | ||
| if (isMatchingJobByName(job, "unstable")) { | ||
| return true; | ||
| return { unstable: true, issues: [] }; | ||
| } | ||
|
|
||
| return hasOpenUnstableIssue(job.name, unstableIssues); | ||
| const openUnstableIssues = getOpenUnstableIssues(job.name, unstableIssues); | ||
| if (openUnstableIssues === undefined || openUnstableIssues.length === 0) { | ||
| return { unstable: false, issues: [] }; | ||
| } else { | ||
| return { unstable: true, issues: openUnstableIssues }; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
What do you think about simplifying this func to only return a list of unstable jobs?
This func could be renamed to getUnstableIssues and you could create a wrapper func called isUnstableJob. You can call the inner func only when you need the individual issues
Contributor
Author
There was a problem hiding this comment.
Let me think of a good name for this as there is already a function called getOpenUnstableIssues. But having a wrapper isUnstableJob sounds like a good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the next part of #5149, this PR provides some additional info about unstable and infra flaky jobs.
Testing
NEW FAILURE - The following job has failed:
inductor/test_cudagraph_trees.py::CudaGraphTreeTests::test_aliasing_static_refFLAKY - The following job failed but was likely due to flakiness present on trunk:
The process '/usr/bin/git' failed with exit code 1UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
Credentials could not be loaded, please check your action inputs: Could not load credentials from any providers>>> Lint for torch/onnx/_internal/onnx_proto_utils.py:FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
Process completed with exit code 1.test_foreach.py::TestForeachCUDA::test_binary_op_list_slow_path__foreach_div_cuda_bool