Skip to content

Upgrade nightly wheels to ROCm5.6#4401

Merged
atalman merged 2 commits intopytorch:mainfrom
jithunnair-amd:upgrade_nightly_wheels_to_rocm5.6
Jul 24, 2023
Merged

Upgrade nightly wheels to ROCm5.6#4401
atalman merged 2 commits intopytorch:mainfrom
jithunnair-amd:upgrade_nightly_wheels_to_rocm5.6

Conversation

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

@jithunnair-amd jithunnair-amd commented Jul 19, 2023 •
edited
Loading

Follow-up to pytorch/pytorch#105076

@vercel
Copy link
Copy Markdown

vercel bot commented Jul 19, 2023

@jithunnair-amd is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm labels Jul 19, 2023
@jithunnair-amd
Copy link
Copy Markdown
Collaborator Author

jithunnair-amd commented Jul 19, 2023 •
edited
Loading

torchaudio/torchvision builds are failing for ROCm5.6: https://github.com/pytorch/test-infra/actions/runs/5601869843/jobs/10246355558?pr=4401 because pytorch nightly wheels weren't yet available for ROCm5.6 ... need to retrigger

@jithunnair-amd
Copy link
Copy Markdown
Collaborator Author

jithunnair-amd commented Jul 21, 2023 •
edited
Loading

All ROCm CI jobs passed. @atalman please review and merge
This failure https://github.com/pytorch/test-infra/actions/runs/5601869874/job/15175252577?pr=4401 seems to be related, but not sure if a code change is needed

@jithunnair-amd
Copy link
Copy Markdown
Collaborator Author

jithunnair-amd commented Jul 21, 2023

All ROCm CI jobs passed. @atalman please review and merge This failure https://github.com/pytorch/test-infra/actions/runs/5601869874/job/15175252577?pr=4401 seems to be related, but not sure if a code change is needed

I think my fix worked: https://github.com/pytorch/test-infra/actions/runs/5627103250/job/15249101952?pr=4401

@Beinsezii Beinsezii mentioned this pull request Jul 22, 2023
Merged
@jithunnair-amd jithunnair-amd mentioned this pull request Jul 22, 2023
Closed
atalman
atalman approved these changes Jul 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit c1057a6 into pytorch:main Jul 24, 2023
@jithunnair-amd jithunnair-amd mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jithunnair-amd @atalman @facebook-github-bot