Skip to content

CMake: support find_package#435

Closed
luncliff wants to merge 1 commit intopytorch:mainfrom
luncliff:main
Closed

CMake: support find_package#435
luncliff wants to merge 1 commit intopytorch:mainfrom
luncliff:main

Conversation

@luncliff
Copy link
Copy Markdown

@luncliff luncliff commented Mar 25, 2022

Resolves #320

Changes

  • Create TensorpipeConfig.cmake from the template
  • Use CMAKE_INSTALL_DATAROOTDIR for share/Tensorpipe
  • Add pytensorpipe to install targets
find_package(Tensorpipe CONFIG REQUIRED)
$ cmake -Bbuild -DTensorpipe_DIR=/path/to/install/share/cmake/Tensorpipe # ...

Install result should be like this.

$ tree .
.
├── include
│   └── tensorpipe
├── lib
│   ├── libtensorpipe.so
│   ├── libtensorpipe_cuda.so
│   ├── libtensorpipe_uv.a
│   └── pytensorpipe.cpython-38-x86_64-linux-gnu.so
└── share
    └── cmake
        └── Tensorpipe
            ├── TensorpipeConfig.cmake
            ├── TensorpipeTargets-debug.cmake
            └── TensorpipeTargets.cmake

Related Works

* Create TensorpipeConfig.cmake from the template
* Use CMAKE_INSTALL_DATAROOTDIR for share/Tensorpipe
@luncliff luncliff changed the title Cmake: support find_package CMake: support find_package Mar 25, 2022
@talregev
Copy link
Copy Markdown

Any news? why the tests are failing? Should we run them again?

@luncliff luncliff closed this by deleting the head repository Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake: config file is not installed along targets file

3 participants