[TENSOR MERGE] Reorganize fields of TensorDerived into Tensor#9632
Closed
ezyang wants to merge 9 commits intopytorch:masterfrom
Closed
[TENSOR MERGE] Reorganize fields of TensorDerived into Tensor#9632ezyang wants to merge 9 commits intopytorch:masterfrom
ezyang wants to merge 9 commits intopytorch:masterfrom
Conversation
This pops off refcount_, storage_, storage_offset_; there are now no more direct accesses to these fields and we can make them private (with appropriate friending).
Devirtualize functions Remove baseclass deconstructor Add _retain
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves us towards deleting the TensorDerived classes. Billing of changes:
Stacked on #9627
Just these commits: https://github.com/pytorch/pytorch/pull/9632/files/22692921b17c8f8f4d5caa6aeecc303777a479d9..HEAD