Skip to content

Update XLA pin#92897

Closed
IvanYashchuk wants to merge 3 commits intopytorch:masterfrom
IvanYashchuk:xla-symeig-pin
Closed

Update XLA pin#92897
IvanYashchuk wants to merge 3 commits intopytorch:masterfrom
IvanYashchuk:xla-symeig-pin

Conversation

@IvanYashchuk
Copy link
Copy Markdown
Collaborator

@IvanYashchuk IvanYashchuk commented Jan 24, 2023 •
edited by pytorch-bot Bot
Loading

Updating the pin to point to pytorch/xla#3272.
It should resolve XLA failures introduced after merging #70988.

cc @bdhirsh

@IvanYashchuk
Update XLA pin
3e6d226 
Updating the pin pointing to pytorch/xla#3272
It should resolve XLA failures introduced after merging pytorch#70988
@IvanYashchuk IvanYashchuk added module: xla Related to XLA support ciflow/trunk Trigger trunk jobs on your pull request ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow labels Jan 24, 2023
@IvanYashchuk IvanYashchuk requested a review from kit1980 January 24, 2023 11:48
@IvanYashchuk IvanYashchuk requested a review from a team as a code owner January 24, 2023 11:48
@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Jan 24, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92897

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 21a1c2f:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@IvanYashchuk IvanYashchuk mentioned this pull request Jan 24, 2023
Merged
alanwaketan
alanwaketan reviewed Jan 24, 2023
View reviewed changes
Comment thread .github/ci_commit_pins/xla.txt Outdated
@@ -1 +1 @@
frobenius_norm
ac3973e96086a42232cd726626b8165cd13b6ee9
Copy link
Copy Markdown
Collaborator

@alanwaketan alanwaketan Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need the commit hash on the pt/xla master:
282567afcc41d2d9703d7002f6a435ec9fc51447

As pt/xla pin usually does't work with fork PR.

Copy link
Copy Markdown
Contributor

@kit1980 kit1980 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated.

@alanwaketan alanwaketan requested a review from JackCaoG January 24, 2023 18:03
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Jan 24, 2023

the pr doesn't make ci pass

/tmp/pytorch/xla/torch_xla/csrc/tensor_methods.cpp:2391:51: error: cannot define or redeclare 'linalg_eigh' here because namespace 'tensor_methods' does not enclose namespace 'XLATensor'
std::tuple<XLATensorPtr, XLATensorPtr> XLATensor::linalg_eigh(
                                       ~~~~~~~~~~~^
/tmp/pytorch/xla/torch_xla/csrc/tensor_methods.cpp:2394:28: error: use of undeclared identifier 'uplo_str'
  char uplo = std::toupper(uplo_str[0]);
                           ^
/tmp/pytorch/xla/torch_xla/csrc/tensor_methods.cpp:2396:66: error: no member named 'ops' in namespace 'torch::lazy'
  torch::lazy::NodePtr node = torch::lazy::MakeNode<torch::lazy::ops::SymEig>(

Can we make sure to check pytorch/xla build before merging the offending pr?

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Jan 24, 2023

Can we make sure to check pytorch/xla build before merging the offending pr?

@JackCaoG so this one is not good pytorch/xla#3272?
I saw it had build errors.

@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Jan 24, 2023

Can we make sure to check pytorch/xla build before merging the offending pr?

@JackCaoG so this one is not good pytorch/xla#3272? I saw it had build errors.

no, the build still fail with this change, we need to work on another fix or revert the pytorch pr for now.

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Jan 24, 2023

no, the build still fail with this change, we need to work on another fix or revert the pytorch pr for now.

I'll revert the PyTorch PR.

@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Jan 24, 2023

@kit1980 Thanks, I will try to work on a fix in the mean time.

@kit1980 kit1980 closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwaketan alanwaketan alanwaketan approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow module: xla Related to XLA support open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@IvanYashchuk @JackCaoG @kit1980 @alanwaketan @bdhirsh @pytorchbot