Remove cffi dependency as it doesn't look like we're using it#92738
Remove cffi dependency as it doesn't look like we're using it#92738albanD wants to merge 1 commit intopytorch:masterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92738
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f8a3c16: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
||
| # Install PyTorch conda deps, as per https://github.com/pytorch/pytorch README | ||
| CONDA_COMMON_DEPS="astunparse pyyaml mkl=2022.0.1 mkl-include=2022.0.1 setuptools cffi six" | ||
| CONDA_COMMON_DEPS="astunparse pyyaml mkl=2022.0.1 mkl-include=2022.0.1 setuptools six" |
There was a problem hiding this comment.
Actually, is six still needed? I think it was there for python2
There was a problem hiding this comment.
I don't think it is strictly needed no as we don't need these constructs anymore. But it is used quite a bit in the codebase. So we would need to remove use of it first before being able to remove it from the builds.
There was a problem hiding this comment.
will create an issue for dropping it eventually
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Maybe this will go horribly wrong in CI but works fine without it locally!
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire