Skip to content

Added keep_key option to Grouper#92532

Closed
SvenDS9 wants to merge 3 commits intopytorch:masterfrom
SvenDS9:keep_key_feature
Closed

Added keep_key option to Grouper#92532
SvenDS9 wants to merge 3 commits intopytorch:masterfrom
SvenDS9:keep_key_feature

Conversation

@SvenDS9
Copy link
Contributor

@SvenDS9 SvenDS9 commented Jan 18, 2023

Fixes meta-pytorch/data#256

The testing of this module is currently suboptimal in general. We should improve this in the future.

@ejguan

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92532

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 6b28a54:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SvenDS9 (d9cceed7f05319e2079e9a500c3cad0f677e2aee)

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Jan 18, 2023
ejguan
ejguan reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. In general, looks good to me with a few nit comments below

torch/utils/data/datapipes/iter/grouping.py Outdated
Copy link
Contributor

@ejguan ejguan Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: resulting in (key, [items]), otherwise returning [items].

@ejguan
Copy link
Contributor

ejguan commented Jan 18, 2023

And, please fix the lint Error as well. You can find doc in https://github.com/pytorch/pytorch/wiki/lintrunner

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 20, 2023
ejguan
ejguan approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@ejguan
Copy link
Contributor

ejguan commented Jan 23, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 23, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 23, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 23, 2023

Merge failed

Reason: 1 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ejguan
Copy link
Contributor

ejguan commented Jan 23, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 23, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 23, 2023

Successfully rebased keep_key_feature onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout keep_key_feature && git pull --rebase)

@SvenDS9
Copy link
Contributor Author

SvenDS9 commented Jan 25, 2023 •
edited
Loading

Dear @ejguan
for some reason this PR seems to have not been merged yet.
Could you please have a quick look?
Thanks a lot in advance

@ejguan
Copy link
Contributor

ejguan commented Jan 25, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Successfully rebased keep_key_feature onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout keep_key_feature && git pull --rebase)

@ejguan
Copy link
Contributor

ejguan commented Jan 25, 2023

@pytorchbot merge -f "ignore flaky test"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejguan ejguan ejguan approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: dataloader release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support keep_key in Grouper?

5 participants

@SvenDS9 @ejguan @pytorchmergebot @soulitzer @pytorchbot