Skip to content

[BE] Do not package caffe2 in wheel (#87986)#90433

Merged
atalman merged 1 commit intopytorch:release/1.13from
atalman:caffe2_cherry
Dec 8, 2022
Merged

[BE] Do not package caffe2 in wheel (#87986)#90433
atalman merged 1 commit intopytorch:release/1.13from
atalman:caffe2_cherry

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Dec 8, 2022

If PyTorch is build without caffe2 integration, do not package unusable .py files/headers

Same is true about functorch - don't package it unless building with functorch (although, I wonder if we should remove this option at some point in the future)

Followup after pytorch/builder#1181

Pull Request resolved: #87986
Approved by: https://github.com/seemethere

If PyTorch is build without caffe2 integration, do not package unusable
.py files/headers

Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future)

Followup after pytorch/builder#1181

Pull Request resolved: pytorch#87986
Approved by: https://github.com/seemethere
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 8, 2022
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 8, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90433

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit 472dba3:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@atalman atalman merged commit 49444c3 into pytorch:release/1.13 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants