Skip to content

[build] disable test_expect for pinning cmake to 3.5* in dockerfiles repo#8850

Merged
soumith merged 2 commits intopytorch:masterfrom
ssnl:cmake_ver
Jun 25, 2018
Merged

[build] disable test_expect for pinning cmake to 3.5* in dockerfiles repo#8850
soumith merged 2 commits intopytorch:masterfrom
ssnl:cmake_ver

Conversation

@ssnl
Copy link
Collaborator

@ssnl ssnl commented Jun 25, 2018

No description provided.

@ssnl ssnl changed the title [test ci]] pin pytorch-linux-xenial* to use cmake 3.5* [test CI] pin pytorch-linux-xenial* to use cmake 3.5* Jun 25, 2018
@ssnl ssnl force-pushed the cmake_ver branch 4 times, most recently from 219e7b2 to 3f67e95 Compare June 25, 2018 15:54
@ssnl ssnl changed the title [test CI] pin pytorch-linux-xenial* to use cmake 3.5* [build] pin pytorch-linux-xenial* to use cmake 3.5* Jun 25, 2018
@ssnl ssnl changed the title [build] pin pytorch-linux-xenial* to use cmake 3.5* [build] pin pytorch-linux-xenial-cuda* to use cmake 3.5* Jun 25, 2018
@ssnl ssnl requested review from Yangqing, ezyang, orionr and yf225 June 25, 2018 16:09
orionr
orionr approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump of CMake to 3.5 looks good. @ezyang might have comments on how to pin CMake, though.

.jenkins/pytorch/build.sh Outdated
if which conda; then
conda uninstall -y cmake
fi
sudo apt-get install -y --no-install-recommends cmake=3.5\*

This comment was marked as off-topic.

Sign in to view

@yf225
Copy link
Contributor

yf225 commented Jun 25, 2018

We should probably do it in pytorch-dockerfiles instead, because for people who run build.sh locally this will change their CMake installation.

To do that we probably need to disable test_expect first, update the CMake version in pytorch-dockerfiles, and then enable test_expect again with the correct CMake version.

@ssnl ssnl changed the title [build] pin pytorch-linux-xenial-cuda* to use cmake 3.5* [build] disable test_expect to pin pytorch-linux-xenial-cuda* to use cmake 3.5* Jun 25, 2018
@ssnl ssnl changed the title [build] disable test_expect to pin pytorch-linux-xenial-cuda* to use cmake 3.5* [build] disable test_expect to pin cmake to 3.5* Jun 25, 2018
@ssnl ssnl changed the title [build] disable test_expect to pin cmake to 3.5* [build] disable test_expect for pinning cmake to 3.5* in dockerfiles repo Jun 25, 2018
@soumith soumith merged commit 2b926aa into pytorch:master Jun 25, 2018
@ssnl ssnl deleted the cmake_ver branch June 25, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soumith soumith soumith approved these changes

@yf225 yf225 yf225 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@Yangqing Yangqing Awaiting requested review from Yangqing

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@zdevito zdevito Awaiting requested review from zdevito

+1 more reviewer

@orionr orionr orionr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ssnl @yf225 @orionr @soumith @ezyang