[easy][caffe2] Export clang compilation datatbase in setuptools build#8811
Merged
bddppq merged 1 commit intopytorch:masterfrom Jun 22, 2018
Merged
[easy][caffe2] Export clang compilation datatbase in setuptools build#8811bddppq merged 1 commit intopytorch:masterfrom
bddppq merged 1 commit intopytorch:masterfrom
Conversation
houseroad
approved these changes
Jun 22, 2018
pjh5
approved these changes
Jun 22, 2018
Contributor
pjh5
left a comment
There was a problem hiding this comment.
Do you want to add this here as well https://github.com/pytorch/pytorch/blob/master/tools/build_pytorch_libs.sh#L245 ?
Contributor
Author
|
@pjh5 That one already does pytorch/tools/build_pytorch_libs.sh Line 264 in fd32cc6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.