Skip to content

[ROCm] set nvfuser default to disabled, keep CI (#86369)#86725

Merged
atalman merged 1 commit intopytorch:release/1.13from
ROCm:release/1.13_rocm_disable_nvfuser
Oct 12, 2022
Merged

[ROCm] set nvfuser default to disabled, keep CI (#86369)#86725
atalman merged 1 commit intopytorch:release/1.13from
ROCm:release/1.13_rocm_disable_nvfuser

Conversation

@jeffdaily
Copy link
Collaborator

Bug fix. nvfuser is functional for ROCm on gfx906, but some tests are failing for other gfx targets. Disable nvfuser until all features are verified. Users may still opt-in by setting the known env var PYTORCH_JIT_ENABLE_NVFUSER=1. This PR sets this env var for the github actions workflow for ROCm since all current CI hosts are gfx906.
Pull Request resolved: #86369
Approved by: https://github.com/huydhn

Bug fix. nvfuser is functional for ROCm on gfx906, but some tests are failing for other gfx targets. Disable nvfuser until all features are verified. Users may still opt-in by setting the known env var PYTORCH_JIT_ENABLE_NVFUSER=1. This PR sets this env var for the github actions workflow for ROCm since all current CI hosts are gfx906.
Pull Request resolved: pytorch#86369
Approved by: https://github.com/huydhn
@jeffdaily jeffdaily requested a review from a team as a code owner October 11, 2022 21:09
@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: releng release notes category labels Oct 11, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86725

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 9ff6db0:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 12, 2022
@atalman atalman merged commit 5be45fc into pytorch:release/1.13 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request module: rocm AMD GPU support for Pytorch open source release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants