Fixes #8508. Upcasted loc to 1-d if a scalar loc is provided to MultivariateNormal#8543
Merged
soumith merged 2 commits intopytorch:masterfrom Jun 25, 2018
Merged
Conversation
… to MultivariateNormal.
be33455 to
b151efd
Compare
Contributor
Author
|
The failed CI builds are due to docker not being able to pull some images (example: |
Contributor
|
@pytorchbot retest this please |
Contributor
Author
fritzo
approved these changes
Jun 25, 2018
fritzo
requested changes
Jun 25, 2018
Collaborator
fritzo
left a comment
There was a problem hiding this comment.
Could you avoid updating loc in-place?
soumith
approved these changes
Jun 25, 2018
Collaborator
soumith
left a comment
There was a problem hiding this comment.
will merge after contbuilds pass
Contributor
Author
|
@soumith Notification: Builds have passed |
Collaborator
|
thanks Praveen! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix unsqueezes the
locargument to make it 1-Dimensional intorch.distributions.MultivariateNormal.__init__if the providedlocis a scalar thereby preventing the SIGFPE.This is a simple fix for #8508