Eliminates noisy assert spew when running test_cuda.py#8531
Merged
soumith merged 3 commits intopytorch:masterfrom Jun 15, 2018
Merged
Eliminates noisy assert spew when running test_cuda.py#8531soumith merged 3 commits intopytorch:masterfrom
soumith merged 3 commits intopytorch:masterfrom
Conversation
ezyang
approved these changes
Jun 15, 2018
apaszke
approved these changes
Jun 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #8342.
Currently, running test_cuda.py results in some asserts triggering and writing to stderr. This can be seen in all recent CI runs, for example. These asserts are expected, however. They and the test that intentionally triggers them were added in #7647.
Printing asserts during the tests is noisy and misleading. This PR address the issue by "muting" stderr on the existing subprocesses used by this test. The actual RuntimeError is captured separately and returned for examination, so if the error differs from what's expected it will still be reported. Muting the stderr on these subprocesses does not affect the main process, and other errors will be reported as usual.