Merged
Conversation
This is a short-term fix for a serious regression in functorch (pytorch/functorch#989). Additional things this PR does: - the out= tests for nn.functional.linear fail after the revert. I added some xfails. These xfails were present in the original PR (#75195). - the profiler tests fail on the revert, so I updated the expecttests for the profiler tests Test Plan: - test offline that the functorch regression was fixed Pull Request resolved: #82504 Approved by: https://github.com/ngimel, https://github.com/ezyang, https://github.com/atalman
Contributor
🔗 Helpful links
❌ 2 New Failures, 3 PendingAs of commit 59d3615 (more details on the Dr. CI page): Expand to see more
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Contributor
Author
|
This is the cherry-pick of #82504 onto release/1.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a short-term fix for a serious regression in functorch
(pytorch/functorch#989).
Additional things this PR does:
some xfails. These xfails were present in the original PR (Dispatch to mv rather than mm in the case that tensor1.ndim == 1 and tensor2.ndim == 2 #75195).
for the profiler tests
Test Plan:
Pull Request resolved: Revert #75195 #82504
Approved by: https://github.com/ngimel, https://github.com/ezyang, https://github.com/atalman