[DON'T RETEST] [WIP] Initialize CUDA test flags in common_cuda only once#8253
Closed
yf225 wants to merge 1 commit intopytorch:masterfrom
Closed
[DON'T RETEST] [WIP] Initialize CUDA test flags in common_cuda only once#8253yf225 wants to merge 1 commit intopytorch:masterfrom
yf225 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
@pytorchbot retest this please |
Contributor
|
@pytorchbot retest this please |
ezyang
reviewed
Jun 9, 2018
| cls.__instance = object.__new__(cls) | ||
| return cls.__instance | ||
|
|
||
| def __init__(self): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This was referenced Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to be a better fix for #8246 by initializing the CUDA test flags in
common_cudaonly once, to avoid the duplicated import ofTEST_CUDNN-> CUDA OOM issue on Windows.We need to loop the test multiple times in CI to make sure there is no CUDA OOM error from this change.