Skip to content

Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…#81884

Merged
atalman merged 1 commit intopytorch:release/1.12from
atalman:cherry_pick_81058
Jul 21, 2022
Merged

Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…#81884
atalman merged 1 commit intopytorch:release/1.12from
atalman:cherry_pick_81058

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Jul 21, 2022

…aries (#81058) (#81058)

Summary:
Fixes: #80489

Test using cuda 11.3 manywheel binary:

import torch
print(torch.__version__)
print(torch._C._PYBIND11 (https://github.com/pytorch/pytorch/commit/d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)

Output

1.13.0.dev20220707+cu113
_cxxabi1011

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102

import torch
print(torch.__version__)
print(torch._C._PYBIND11 (https://github.com/pytorch/pytorch/commit/d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)

Output

1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)

Related Builder PR: pytorch/builder#1083

Test PR: #81232

Pull Request resolved: #81058
Approved by: https://github.com/zou3519, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d552ba3b4f53da9b6a5f6e0463111e43b367ef8a

Reviewed By: DanilBaibak

Differential Revision: D37813240

Pulled By: atalman

fbshipit-source-id: 94d94e777b0e9d5da106173c06117b3019ba71c4

@atalman
Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…
dd558e4 
…aries (pytorch#81058) (pytorch#81058)

Summary:
Fixes: pytorch#80489

Test using cuda 11.3 manywheel binary:
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (pytorch@d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
````

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
```

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (pytorch@d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)
```

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)
```

Related Builder  PR: pytorch/builder#1083

Test PR: pytorch#81232

Pull Request resolved: pytorch#81058
Approved by: https://github.com/zou3519, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d552ba3b4f53da9b6a5f6e0463111e43b367ef8a

Reviewed By: DanilBaibak

Differential Revision: D37813240

Pulled By: atalman

fbshipit-source-id: 94d94e777b0e9d5da106173c06117b3019ba71c4
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jul 21, 2022 •
edited
Loading

🔗 Helpful links

❌ 2 New Failures

As of commit dd558e4 (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/2)

Step: "Save test results" (full log | diagnosis details | 🔁 rerun)

2022-07-21T19:15:50.2252147Z ##[error]No files ...ath: test/**/*.xml. No artifacts will be uploaded. 
2022-07-21T19:15:50.0216515Z   retention-days: 14
2022-07-21T19:15:50.0216905Z   if-no-files-found: error
2022-07-21T19:15:50.0217291Z   path: test/**/*.xml
2022-07-21T19:15:50.0217595Z env:
2022-07-21T19:15:50.0217891Z   IN_CI: 1
2022-07-21T19:15:50.0218201Z   IS_GHA: 1
2022-07-21T19:15:50.0218531Z   GIT_DEFAULT_BRANCH: master
2022-07-21T19:15:50.0219093Z   DOCKER_HOST: unix:///run/user/1004/docker.sock
2022-07-21T19:15:50.0219799Z   GPU_FLAG: --device=/dev/mem --device=/dev/kfd --device=/dev/dri/renderD128 --device=/dev/dri/renderD129 --group-add video --group-add daemon
2022-07-21T19:15:50.0220390Z ##[endgroup]
2022-07-21T19:15:50.2252147Z ##[error]No files were found with the provided path: test/**/*.xml. No artifacts will be uploaded.
2022-07-21T19:15:50.2317024Z ##[group]Run set -x
2022-07-21T19:15:50.2317573Z �[36;1mset -x�[0m
2022-07-21T19:15:50.2318176Z �[36;1mpython3 -m pip install -r requirements.txt�[0m
2022-07-21T19:15:50.2318893Z �[36;1mpython3 -m pip install boto3==1.19.12�[0m
2022-07-21T19:15:50.2319726Z �[36;1mpython3 -m tools.stats.print_test_stats --upload-to-s3 --compare-with-s3 test�[0m
2022-07-21T19:15:50.2404711Z shell: /bin/bash --noprofile --norc -e -o pipefail {0}
2022-07-21T19:15:50.2405054Z env:
2022-07-21T19:15:50.2405314Z   IN_CI: 1
2022-07-21T19:15:50.2405583Z   IS_GHA: 1
2022-07-21T19:15:50.2405861Z   GIT_DEFAULT_BRANCH: master

See GitHub Actions build pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-21T14:19:42.4731928Z ##[error]Process completed with exit code 1. 
2022-07-21T14:19:42.4288496Z �[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m �[0m�[35mtypeerror�[0m     at pickVersionFromRegistryDocument (/usr/share/npm/lib/fetch-package-metadata.js:134:20)
2022-07-21T14:19:42.4290446Z �[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m �[0m�[35mtypeerror�[0m     at /usr/share/npm/node_modules/iferr/index.js:13:50
2022-07-21T14:19:42.4291188Z �[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m �[0m�[35mtypeerror�[0m This is an error with npm itself. Please report this error at:
2022-07-21T14:19:42.4293416Z �[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m �[0m�[35mtypeerror�[0m     <http://github.com/npm/npm/issues>
2022-07-21T14:19:42.4633427Z �[0m
2022-07-21T14:19:42.4634338Z �[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m�[35m�[0m Please include the following file with any support request:
2022-07-21T14:19:42.4634810Z �[0m�[37m�[40mnpm�[0m �[0m�[31m�[40mERR!�[0m�[35m�[0m     /var/lib/jenkins/workspace/npm-debug.log
2022-07-21T14:19:42.4697169Z �[0m+ cleanup
2022-07-21T14:19:42.4697485Z + retcode=1
2022-07-21T14:19:42.4697717Z + set +x
2022-07-21T14:19:42.4731928Z ##[error]Process completed with exit code 1.
2022-07-21T14:19:42.4775040Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-07-21T14:19:42.4775276Z with:
2022-07-21T14:19:42.4775695Z   github-token: ***
2022-07-21T14:19:42.4775863Z env:
2022-07-21T14:19:42.4776014Z   IN_CI: 1
2022-07-21T14:19:42.4776166Z   IS_GHA: 1
2022-07-21T14:19:42.4776342Z   GIT_DEFAULT_BRANCH: master
2022-07-21T14:19:42.4776529Z ##[endgroup]
2022-07-21T14:19:42.4807303Z ##[group]Run nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a
2022-07-21T14:19:42.4807536Z with:
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@atalman atalman merged commit 0e43325 into pytorch:release/1.12 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atalman @facebook-github-bot @zou3519