Closed
Conversation
Fixes type inference issue where update is written to a temporary optional holder, other than the updating the graph.
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 2701937 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
Thanks!! |
Collaborator
Author
|
This one could be closed since changes here are included in #83067. |
davidberard98
approved these changes
Aug 10, 2022
Contributor
davidberard98
left a comment
There was a problem hiding this comment.
LGTM, but same as other PR - let's wait for #83067, I would expect another merge conflict in test_jit_cuda_fuser.py
Collaborator
Author
|
I'm just going to close this one since there's no code diff and the original changes have been merged via #83067 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes type inference issue where update is written to a temporary optional holder, other than the updating the graph.
Fixes CI failure in #81725