Skip to content

Update operator documentation with markdown descriptions and interfaces#8085

Merged
ezyang merged 8 commits intopytorch:masterfrom
MatthewInkawhich:master
Jun 15, 2018
Merged

Update operator documentation with markdown descriptions and interfaces#8085
ezyang merged 8 commits intopytorch:masterfrom
MatthewInkawhich:master

Conversation

@MatthewInkawhich
Copy link
Contributor

Added markdown descriptions and interfaces to operator source (.cc) files. Initial pull request contains three changed files. Will push rest of completed files when build succeeds.

ATTN: @orionr @janelu1

@onnxbot onnxbot added the caffe2 label Jun 3, 2018
@ezyang
Copy link
Contributor

ezyang commented Jun 6, 2018

Needs a rebase

@ezyang
Copy link
Contributor

ezyang commented Jun 10, 2018

19:53:09 /opt/conda/conda-bld/caffe2_1528573424681/work/caffe2/operators/sqrt_op.cc:98:1: error: expected ‘}’ at end of input
19:53:09  } // namespace caffe2
19:53:09  ^

@ezyang
Copy link
Contributor

ezyang commented Jun 12, 2018

@pytorchbot retest this please

@MatthewInkawhich
Copy link
Contributor Author

@ezyang Just rebased again and added all of my new changes. 40/42 checks passed, but it looks like the master upstream branch's build is failing as well. Any suggestions?

@ezyang
Copy link
Contributor

ezyang commented Jun 15, 2018

flaky tests and upstream breakage. You're good

@ezyang ezyang merged commit b10c94b into pytorch:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants