Skip to content

Fix code that triggers BytesWarning #79868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aphedges wants to merge 4 commits into from
Closed

Fix code that triggers BytesWarning #79868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9809c6
Fix BytesWarning in torch.load()
aphedges Mar 27, 2022
d3fe15e
Fix BytesWarning in test_cpp_warnings_have_python_context
aphedges Jun 17, 2022
3c6d074
Fix BytesWarning in test_MaxUnpool_index_errors
aphedges Jun 20, 2022
aa0f624
Run tests with the -bb Python option
aphedges Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/run_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def get_executable_command(options, allow_pytest, disable_coverage=False):
if options.coverage and not disable_coverage:
executable = ["coverage", "run", "--parallel-mode", "--source=torch"]
else:
executable = [sys.executable]
executable = [sys.executable, "-bb"]
if options.pytest:
if allow_pytest:
executable += ["-m", "pytest"]
Expand Down
3 changes: 2 additions & 1 deletion test/test_nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15157,9 +15157,10 @@ def test_MaxUnpool_index_errors(self, device, module_name, module_size, output_s
[sys.executable, '-c', script],
cwd=os.path.dirname(os.path.realpath(__file__)),
capture_output=True,
text=True,
)

output = str(p.stdout) + '\n' + str(p.stderr)
output = p.stdout + '\n' + p.stderr

error_msg = error_msgs[module_name]

Expand Down
4 changes: 2 additions & 2 deletions test/test_torch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ def cpp_warn_fn():

# Checks for cpp context in the warning message
escaped_warning_message = str(warning.message).encode('unicode_escape')
self.assertTrue(re.search(s, str(escaped_warning_message), re.IGNORECASE) is not None)
self.assertTrue(re.search(s, repr(escaped_warning_message), re.IGNORECASE) is not None)

# Checks the Python features of the warning
# Note: the eager mode warning refers to the line in the function
Expand All @@ -764,7 +764,7 @@ def cpp_warn_fn():

# Checks for cpp context in the warning message
escaped_warning_message = str(warning.message).encode('unicode_escape')
self.assertTrue(re.search(s, str(escaped_warning_message), re.IGNORECASE) is not None)
self.assertTrue(re.search(s, repr(escaped_warning_message), re.IGNORECASE) is not None)

# Checks the Python features of the warning
# Note: the jitted warning's lineno refers to the call to the jitted
Expand Down
2 changes: 1 addition & 1 deletion torch/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def _is_zipfile(f) -> bool:
start = f.tell()

byte = f.read(1)
while byte != "":
while byte != b"":
read_bytes.append(byte)
if len(read_bytes) == 4:
break
Expand Down