Closed
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Contributor
Author
|
Requested by @pietern |
gchanan
reviewed
May 1, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
Should we merge this with the context?
Contributor
|
Thanks @ezyang! |
Contributor
Author
|
@gchanan and I had offline conversation, and ATen/Context.h is doing something different than the Registry. (This header needs more docs but we'll put it in afterwards.) |
Contributor
Contributor
Author
|
I'm OK with this but I can't approve my own PR. |
apaszke
approved these changes
May 7, 2018
Contributor
Author
|
Obsoleted by cpu/gpu split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing C10 needs is the ability for separate compilation units (a.k.a. dynamic libraries) to register, at static initialization time, some data which we can subsequently look up in a map. This is what Registry provides. I'm personally using this to help split apart CPU/CUDA (but make it so that functions available from the CPU interface "grow" more functionality when you dlopen the CUDA library).
It needs more docs; right now it's a straight copy paste from Caffe2. It does NOT handle namespaces correctly; @pietern has a patch to fix this stacked on top of this.
Signed-off-by: Edward Z. Yang ezyang@fb.com