OpInfo for nn.functional.cross_entropy#63547
Closed
krshrimali wants to merge 16 commits intopytorch:masterfrom
Closed
OpInfo for nn.functional.cross_entropy#63547krshrimali wants to merge 16 commits intopytorch:masterfrom
nn.functional.cross_entropy#63547krshrimali wants to merge 16 commits intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3e59876 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
23 tasks
Collaborator
|
@zou3519 The failing tests here look awful lot like the ones in #63854. Given that |
Closed
pmeier
reviewed
Aug 31, 2021
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
zou3519
reviewed
Oct 4, 2021
Contributor
zou3519
left a comment
There was a problem hiding this comment.
This looks pretty good. I had one suggestion for improving the test case, please let me know what you think
zou3519
reviewed
Oct 21, 2021
zou3519
reviewed
Oct 21, 2021
zou3519
reviewed
Nov 1, 2021
Comment on lines
+8519
to
+8522
| skips=( | ||
| # AssertionError: False is not true : Scalars failed to compare as equal! 0 != 1536 | ||
| # test_ops.TestJitCUDA.test_variant_consistency_jit_nn_functional_cross_entropy_cuda_float32 leaked | ||
| # 1536 bytes CUDA memory on device 0 |
zou3519
approved these changes
Nov 1, 2021
Contributor
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: pytorch/functorch#78 and #54261
TODOs:
test_nn.pyforcross_entropy.cc: @mruberry @zou3519
cc @albanD @mruberry @jbschlosser @walterddr