Skip to content

add OpInfo for torch.nn.functional.softplus#62317

Closed
pmeier wants to merge 4 commits intopytorch:masterfrom
pmeier:opinfo/softplus
Closed

add OpInfo for torch.nn.functional.softplus#62317
pmeier wants to merge 4 commits intopytorch:masterfrom
pmeier:opinfo/softplus

Conversation

@pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 28, 2021

@pmeier pmeier added module: nn Related to torch.nn module: testing Issues related to the torch.testing module (not tests) labels Jul 28, 2021
@pmeier pmeier requested review from mruberry and zou3519 July 28, 2021 09:00
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9b441f4 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 28, 2021
mruberry
mruberry reviewed Jul 30, 2021
View reviewed changes
@mruberry
Copy link
Collaborator

mruberry commented Jul 30, 2021

Another jit test failure that we should probably skip for now:

RuntimeError: aliasOp != torch::jit::getOperatorAliasMap().end()INTERNAL ASSERT FAILED at "/var/lib/jenkins/workspace/torch/csrc/jit/passes/utils/check_alias_annotation.cpp":159, please report a bug to PyTorch.

cc @eellison -- is this something about all nn.functional ops? Should they auto-skip that test?

@mruberry
Copy link
Collaborator

mruberry commented Jul 30, 2021

LGTM but @zou3519 might have some ideas about extending the sample inputs

@zou3519 - would you shepherd this PR through?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 2, 2021

@zou3519 merged this pull request in 2e4f566.

@zou3519 zou3519 mentioned this pull request Aug 18, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry left review comments

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: nn Related to torch.nn module: testing Issues related to the torch.testing module (not tests) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pmeier @facebook-github-bot @mruberry @zou3519 @bdhirsh @pytorchbot