Skip to content

add OpInfo for torch.nn.functional.one_hot#62253

Closed
pmeier wants to merge 4 commits intomasterfrom
opinfo/one_hot
Closed

add OpInfo for torch.nn.functional.one_hot#62253
pmeier wants to merge 4 commits intomasterfrom
opinfo/one_hot

Conversation

@pmeier
Copy link
Collaborator

@pmeier pmeier commented Jul 27, 2021

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 27, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 06173d0 (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .clang-tidy
Auto-merging .clang-tidy
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_linux_test.sh
Auto-merging .circleci/scripts/binary_linux_test.sh
CONFLICT (add/add): Merge conflict in .circleci/generate_config_yml.py
Auto-merging .circleci/generate_config_yml.py
CONFLICT (add/add): Merge conflict in .circleci/ecr_gc_docker/gc.py
Auto-merging .circleci/ecr_gc_docker/gc.py
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .clang-tidy
Auto-merging .clang-tidy
CONFLICT (add/add): Merge conflict in .circleci/scripts/binary_linux_test.sh
Auto-merging .circleci/scripts/binary_linux_test.sh
CONFLICT (add/add): Merge conflict in .circleci/generate_config_yml.py
Auto-merging .circleci/generate_config_yml.py
CONFLICT (add/add): Merge conflict in .circleci/ecr_gc_docker/gc.py
Auto-merging .circleci/ecr_gc_docker/gc.py
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@mruberry mruberry requested review from mruberry and zou3519 July 27, 2021 09:20
@ejguan ejguan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 27, 2021
@pmeier pmeier added module: nn Related to torch.nn module: testing Issues related to the torch.testing module (not tests) labels Jul 28, 2021
krshrimali
krshrimali approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @pmeier! Thanks. Left a minor suggestion, but it's not a necessary change. :)

zou3519
zou3519 reviewed Jul 28, 2021
View reviewed changes
zou3519
zou3519 reviewed Jul 28, 2021
View reviewed changes
zou3519
zou3519 reviewed Jul 28, 2021
View reviewed changes
zou3519
zou3519 reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. I added some suggestions for some more test cases to make the OpInfo more complete

@zou3519
Copy link
Contributor

zou3519 commented Jul 29, 2021

The lint failure seems bogus so I am going to land this:

+ for CONFIG in mypy*.ini
+ mypy --config=mypy.ini
torch/fx/_symbolic_trace.py:500:80: error: Argument 5 to "create_proxy" of "TracerBase" has incompatible type "**Dict[str, Optional[Callable[[Any], ParameterProxy]]]"; expected "Optional[str]"  [arg-type]
Found 1 error in 1 file (checked 1398 source files)
+ STATUS=fail
+ '[' -n fail ']'
+ echo 'Please fix the above mypy warnings.'
Please fix the above mypy warnings.
+ false

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 29, 2021

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mruberry
mruberry reviewed Jul 30, 2021
View reviewed changes
mruberry
mruberry approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2021

@zou3519 merged this pull request in ee7d19a.

@zou3519 zou3519 mentioned this pull request Jul 30, 2021
Closed
23 tasks
@github-actions github-actions bot deleted the opinfo/one_hot branch February 12, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@mruberry mruberry mruberry approved these changes

+1 more reviewer

@krshrimali krshrimali krshrimali approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged module: nn Related to torch.nn module: testing Issues related to the torch.testing module (not tests) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pmeier @facebook-github-bot @zou3519 @krshrimali @mruberry @pytorchbot @ejguan