Closed
Conversation
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 714cc3d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mruberry
reviewed
Jul 30, 2021
| (()), | ||
| ((S, )), | ||
| ((S, S)), | ||
| ((S, M, S)) |
Collaborator
There was a problem hiding this comment.
We probably don't even need this case
mruberry
reviewed
Jul 30, 2021
| dtypes=all_types_and(torch.float16, torch.bfloat16, torch.bool), | ||
| supports_forward_ad=True, | ||
| sample_inputs_func=sample_inputs_max_min_binary,), | ||
| OpInfo('nn.functional.relu', |
mruberry
approved these changes
Jul 30, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Awesome! Thanks @krshrimali.
@zou3519 would you like to check this, make sure it has the sample inputs you need, and shepherd it through?
zou3519
approved these changes
Jul 30, 2021
Contributor
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
Yup, can do! |
Contributor
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pytorch/functorch#78 and #54261.
cc: @mruberry