[Profiler] Fix timestamp discrepancy in profiler_kineto.cpp#60070
Closed
gdankel wants to merge 1 commit intopytorch:masterfrom
Closed
[Profiler] Fix timestamp discrepancy in profiler_kineto.cpp#60070gdankel wants to merge 1 commit intopytorch:masterfrom
gdankel wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: PyTorch pull request pytorch#57333 changed high_resolution_clock to system_clock but missed one location in profiler_kineto.cpp. On some platforms (e.g. Windows), high_resolution_clock and system_clock do not map to the same underlying clock and therefore we get mixed timestamps on some platforms. Differential Revision: D29155809 fbshipit-source-id: 1f2f13af3ac3a3d67428aa72e755af5b27c00979
Contributor
💊 CI failures summary and remediationsAs of commit 472b046 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D29155809 |
guotuofeng
approved these changes
Jun 16, 2021
Contributor
|
This pull request has been merged in fd1e925. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PyTorch pull request #57333 changed high_resolution_clock to system_clock but missed one location in profiler_kineto.cpp.
On some platforms (e.g. Windows), high_resolution_clock and system_clock do not map to the same underlying clock and therefore we get mixed timestamps on some platforms.
Differential Revision: D29155809