Support `expand_dims` by asi1024 · Pull Request #57116 · pytorch/pytorch

asi1024 · 2021-04-28T10:10:00Z

This PR implements torch.expand_dims for the compatibility with NumPy’s interface.
cc: @mruberry, @rgommers, @emcastillo and @kmaehashi

facebook-github-bot · 2021-04-28T10:10:07Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/57116
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit fde1880 (more details on the Dr. CI page):

4/4 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/docker/ubuntu/Dockerfile
Auto-merging .circleci/docker/ubuntu/Dockerfile
CONFLICT (add/add): Merge conflict in .circleci/docker/ubuntu-cuda/Dockerfile
Auto-merging .circleci/docker/ubuntu-cuda/Dockerfile
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_definitions.py
Auto-merging .circleci/cimodel/data/binary_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/docker/ubuntu/Dockerfile
Auto-merging .circleci/docker/ubuntu/Dockerfile
CONFLICT (add/add): Merge conflict in .circleci/docker/ubuntu-cuda/Dockerfile
Auto-merging .circleci/docker/ubuntu-cuda/Dockerfile
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/binary_build_definitions.py
Auto-merging .circleci/cimodel/data/binary_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

2 failures not recognized by patterns:

Job	Step	Action
^{Build Error}	^{Config Processing Error (Don't rerun)}	🔁 rerun
^{clang-format / clang-format}	^{Run clang-format}	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

mruberry

Cool! Thanks @asi1024! It's nice to see how much easier adding an alias has become, at least for simple cases.

I have just one question about whether we should alias the inplace version of the op, too. Might as well?

cc @ngimel

mruberry · 2021-04-30T13:02:50Z

    CompositeExplicitAutograd: unsqueeze_

+# expand_dims, alias of unsqueeze
+- func: expand_dims(Tensor(a) self, int dim) -> Tensor(a)


What's your thinking on aliasing the inplace version of the operation, unsqueeze_, as well?

The in-place version is out of Array API standard, so it does not necessarily need to be supported, but I think it's OK to support it. Done in 83a21ff!

Looks great; I made one small tweak to the inplace method docs. I think this is now ready to merge!

facebook-github-bot · 2021-05-02T02:35:28Z

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mruberry · 2021-05-02T22:56:42Z

Hey @asi1024, just fyi I'm going to need to follow-up on one internal hitch with this PR, so it may not land immediately

asi1024 · 2021-05-06T06:24:57Z

@mruberry Thank you! Please let me know if there is any updates 😃

mruberry · 2021-05-06T06:27:19Z

@mruberry Thank you! Please let me know if there is any updates 😃

I will; we're preparing for the PyTorch 1.9 release now, however, so it might take some time to follow-up, unfortunately.

asi1024 · 2021-08-04T07:55:33Z

@mruberry Kindly ping 😃

mruberry · 2021-08-17T06:18:46Z

@mruberry Kindly ping 😃

Thanks for the ping @asi1024. I'm hoping to follow-up on this soon.

mruberry · 2021-09-07T03:29:29Z

@mruberry Kindly ping 😃

Thanks for the ping @asi1024. I'm hoping to follow-up on this soon.

Still haven't forgotten about this. Just trying to work around the PyTorch 1.10 branch cut.

rgommers · 2021-10-28T13:46:06Z

Hey @asi1024, just fyi I'm going to need to follow-up on one internal hitch with this PR, so it may not land immediately

Details, from #58742 (comment):
Adding the alias would be great! expand_dims is on hold just because a dependency of PyTorch also defines an expand_dims function in a way where they can't build with PyTorch if it's added, and we're working with them to resolve this issue. This complication is atypical and unlikely to affect other aliases.

I assume this is a non-public package. Will it be possible to get them to fix it before the 1.11 release @mruberry?

mruberry · 2021-11-10T15:24:50Z

Hey @asi1024, just fyi I'm going to need to follow-up on one internal hitch with this PR, so it may not land immediately

Details, from #58742 (comment): Adding the alias would be great! expand_dims is on hold just because a dependency of PyTorch also defines an expand_dims function in a way where they can't build with PyTorch if it's added, and we're working with them to resolve this issue. This complication is atypical and unlikely to affect other aliases.

I assume this is a non-public package. Will it be possible to get them to fix it before the 1.11 release @mruberry?

Hard to know the timeline but I certainly hope so. I'm reviewing these internal failures today so hope to know more soon.

pytorchbot · 2022-04-12T05:06:45Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

asi1024 added 3 commits April 28, 2021 05:02

Add expand_dims

1b7df8a

Add expand_dims test

8416eb8

Add expand_dims documentation

06ff877

asi1024 requested a review from ezyang as a code owner April 28, 2021 10:10

facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Apr 28, 2021

pytorchbot added the open source label Apr 28, 2021

ezyang removed their request for review April 28, 2021 14:46

mruberry approved these changes Apr 30, 2021

View reviewed changes

mruberry reviewed Apr 30, 2021

View reviewed changes

asi1024 and others added 2 commits April 30, 2021 17:11

Support torch.Tensor.expand_dims_

83a21ff

tweaks inplace method doc

fde1880

pmeier mentioned this pull request May 21, 2021

Python Array API New Operators Tracker #58742

Open

28 tasks

pmeier added the module: python array api Issues related to the Python Array API label Jun 10, 2021

pytorchbot added the Stale label Apr 12, 2022

github-actions Bot closed this May 12, 2022

Conversation

asi1024 commented Apr 28, 2021

Uh oh!

facebook-github-bot commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

2 failures not recognized by patterns:

Uh oh!

mruberry left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mruberry Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

asi1024 Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

mruberry May 2, 2021

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 2, 2021

Uh oh!

mruberry commented May 2, 2021

Uh oh!

asi1024 commented May 6, 2021

Uh oh!

mruberry commented May 6, 2021

Uh oh!

asi1024 commented Aug 4, 2021

Uh oh!

mruberry commented Aug 17, 2021

Uh oh!

mruberry commented Sep 7, 2021

Uh oh!

rgommers commented Oct 28, 2021

Uh oh!

mruberry commented Nov 10, 2021

Uh oh!

pytorchbot commented Apr 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

facebook-github-bot commented Apr 28, 2021 •

edited

Loading

mruberry left a comment •

edited

Loading