Skip to content

[1.8.1] [fix] nn.Embedding: allow changing the padding vector#53986

Merged
malfet merged 1 commit intopytorch:release/1.8from
malfet:malfet/cp-53447
Mar 15, 2021
Merged

[1.8.1] [fix] nn.Embedding: allow changing the padding vector#53986
malfet merged 1 commit intopytorch:release/1.8from
malfet:malfet/cp-53447

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Mar 14, 2021

Fixes #53368

This is a cherry-pick of #53447 into release/1.8 branch

Reviewed By: albanD

Differential Revision: D26946284

Pulled By: jbschlosser

@kshitij12345 @malfet
[fix] nn.Embedding: allow changing the padding vector (pytorch#53447)
cedf453 
Summary:
Fixes pytorch#53368

Pull Request resolved: pytorch#53447

Reviewed By: albanD

Differential Revision: D26946284

Pulled By: jbschlosser

fbshipit-source-id: 54e5eec7da86fa02b1b6e4a235d66976a80764fc
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 14, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit cedf453 (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Mar 14 21:50:16 AssertionError: False is not true 
Mar 14 21:50:16   test_where_scalar_valid_combination_xla_uint8 (__main__.TestTorchDeviceTypeXLA) ... ok (0.034s)
Mar 14 21:50:16 
Mar 14 21:50:16 ======================================================================
Mar 14 21:50:16 FAIL [0.003s]: test_pickle_gradscaler_xla (__main__.TestTorchDeviceTypeXLA)
Mar 14 21:50:16 ----------------------------------------------------------------------
Mar 14 21:50:16 Traceback (most recent call last):
Mar 14 21:50:16   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 290, in instantiated_test
Mar 14 21:50:16     result = test_fn(self, *args)
Mar 14 21:50:16   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 6172, in test_pickle_gradscaler
Mar 14 21:50:16     self.assertTrue(a.is_enabled() if torch.cuda.is_available() else not a.is_enabled())
Mar 14 21:50:16 AssertionError: False is not true
Mar 14 21:50:16 
Mar 14 21:50:16 ----------------------------------------------------------------------
Mar 14 21:50:16 Ran 244 tests in 156.661s
Mar 14 21:50:16 
Mar 14 21:50:16 FAILED (failures=1, skipped=140)
Mar 14 21:50:16 
Mar 14 21:50:16 Generating XML reports...
Mar 14 21:50:16 Generated XML report: test-reports/python-unittest/TEST-TestTorchDeviceTypeXLA-20210314214740.xml
Mar 14 21:50:17 =================== sccache compilation log ===================
Mar 14 21:50:17 + cleanup

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (1/1)

Step: "Check for no AVX instruction by default" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch https://apt.llvm.org/bionic/dists/llvm-toolchain-bionic-9/main/binary-amd64/Packages.gz File has unexpected size (8854 != 8829). Mirror sync in progress? [IP: 199.232.194.49 443] 
   - SHA1:5492873de9965dd98637d3540d4589386887137b [weak]
   - MD5Sum:785a2d97a69a60ec8f963a7b39bfdc90 [weak]
  Release file created at: Sat, 13 Mar 2021 17:46:58 +0000
Get:10 http://archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]
Get:11 http://archive.ubuntu.com/ubuntu bionic-updates/restricted amd64 Packages [353 kB]
Get:12 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages [2163 kB]
Get:13 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages [2394 kB]
Get:14 http://archive.ubuntu.com/ubuntu bionic-updates/multiverse amd64 Packages [31.4 kB]
Fetched 8906 kB in 2s (5456 kB/s)
Reading package lists...
E: Failed to fetch https://apt.llvm.org/bionic/dists/llvm-toolchain-bionic-9/main/binary-amd64/Packages.gz  File has unexpected size (8854 != 8829). Mirror sync in progress? [IP: 199.232.194.49 443]
   Hashes of expected file:
    - Filesize:8829 [weak]
    - SHA256:029e4ac1658b9857030358c18d11bf15baf34db81dc984797e46ea65f9cce0d3
    - SHA1:5492873de9965dd98637d3540d4589386887137b [weak]
    - MD5Sum:785a2d97a69a60ec8f963a7b39bfdc90 [weak]
   Release file created at: Sat, 13 Mar 2021 17:46:58 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.


Exited with code exit status 100

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@malfet malfet changed the title [1.8.1] [fix] nn.Embedding: allow changing the padding vector (#53447) [1.8.1] [fix] nn.Embedding: allow changing the padding vector Mar 14, 2021
@malfet malfet mentioned this pull request Mar 14, 2021
Closed
@malfet malfet merged commit a3e4bf6 into pytorch:release/1.8 Mar 15, 2021
@malfet malfet deleted the malfet/cp-53447 branch March 15, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @facebook-github-bot @kshitij12345