Skip to content

Fix set_device_map docs (#53508)#53822

Merged
malfet merged 1 commit intopytorch:release/1.8from
mrshenli:v1.8
Mar 13, 2021
Merged

Fix set_device_map docs (#53508)#53822
malfet merged 1 commit intopytorch:release/1.8from
mrshenli:v1.8

Conversation

@mrshenli
Copy link
Copy Markdown
Contributor

@mrshenli mrshenli commented Mar 11, 2021

Summary:
This PR has been merged into master after the 1.8.0 branch cut at
115df4f (see original PR: #53508). This PR is to cherry pick it into 1.8.1.

---- Original Commit Description Follows ---

Summary:
Pull Request resolved: #53508

closes #53501

Differential Revision: D26885263

Test Plan: Imported from OSS

Reviewed By: H-Huang

Pulled By: mrshenli

@mrshenli
Fix set_device_map docs (pytorch#53508)
ad27a9c 
Summary:
Pull Request resolved: pytorch#53508

closes pytorch#53501

Differential Revision: D26885263

Test Plan: Imported from OSS

Reviewed By: H-Huang

Pulled By: mrshenli

fbshipit-source-id: dd0493e6f179d93b518af8f082399cacb1c7cba6
@facebook-github-bot facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels Mar 11, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 11, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit ad27a9c (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Mar 11 17:45:11 AssertionError: False is not true 
Mar 11 17:45:11   test_where_scalar_valid_combination_xla_uint8 (__main__.TestTorchDeviceTypeXLA) ... ok (0.032s)
Mar 11 17:45:11 
Mar 11 17:45:11 ======================================================================
Mar 11 17:45:11 FAIL [0.003s]: test_pickle_gradscaler_xla (__main__.TestTorchDeviceTypeXLA)
Mar 11 17:45:11 ----------------------------------------------------------------------
Mar 11 17:45:11 Traceback (most recent call last):
Mar 11 17:45:11   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 290, in instantiated_test
Mar 11 17:45:11     result = test_fn(self, *args)
Mar 11 17:45:11   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 6172, in test_pickle_gradscaler
Mar 11 17:45:11     self.assertTrue(a.is_enabled() if torch.cuda.is_available() else not a.is_enabled())
Mar 11 17:45:11 AssertionError: False is not true
Mar 11 17:45:11 
Mar 11 17:45:11 ----------------------------------------------------------------------
Mar 11 17:45:11 Ran 244 tests in 154.016s
Mar 11 17:45:11 
Mar 11 17:45:11 FAILED (failures=1, skipped=140)
Mar 11 17:45:11 
Mar 11 17:45:11 Generating XML reports...
Mar 11 17:45:11 Generated XML report: test-reports/python-unittest/TEST-TestTorchDeviceTypeXLA-20210311174237.xml
Mar 11 17:45:11 + cleanup
Mar 11 17:45:11 + retcode=1

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@mrshenli mrshenli added this to the 1.8.1 milestone Mar 11, 2021
@mrshenli mrshenli mentioned this pull request Mar 11, 2021
Closed
@mrshenli mrshenli requested review from malfet and seemethere March 11, 2021 17:08
@malfet malfet merged commit c439f85 into pytorch:release/1.8 Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao zhaojuanmao is a code owner

@seemethere seemethere Awaiting requested review from seemethere

Assignees

No one assigned

Labels

cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

1.8.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mrshenli @facebook-github-bot @malfet