Fix downcastOuter contiguity requirements#4848
Closed
zou3519 wants to merge 1 commit intopytorch:masterfrom
Closed
Fix downcastOuter contiguity requirements#4848zou3519 wants to merge 1 commit intopytorch:masterfrom
zou3519 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
14c78a4 to
65ce5a6
Compare
Contributor
Author
|
@pytorchbot retest this please |
Collaborator
|
Discussed offline. Let's remove |
Contributor
Author
|
Closing this in favor of #5052, which replaces usages of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4835
There's a bug in
THCDeviceTensor::downcastOuterwhere it sometimes doesn't recognize a contiguous tensor as being contiguous. For example,yhas valid strides and is contiguous because we don't care about what the stride value is at dimensions that has size 1. This changesdowncastOuterto take that into account, fixing behavior forVolumetricAveragePooling,VolumetricMaxUnpooling, andVolumetricDilatedMaxPoolingand other things that depend on these.Test Plan
New unit test for this behavior.
A lot of the Pooling layers also use
downcastOuterso runtest_nn.