Skip to content

Update the docs of torch.eig about derivative#47598

Closed
mfkasim1 wants to merge 1 commit intopytorch:masterfrom
mfkasim1:eigdocs
Closed

Update the docs of torch.eig about derivative#47598
mfkasim1 wants to merge 1 commit intopytorch:masterfrom
mfkasim1:eigdocs

Conversation

@mfkasim1
Copy link
Contributor

@mfkasim1 mfkasim1 commented Nov 9, 2020

Related: #33090
I just realized that I haven't updated the docs of torch.eig when implementing the backward.
Here's the PR updating the docs about the grad of torch.eig.

cc @albanD

@dr-ci
Copy link

dr-ci bot commented Nov 9, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 84772ba (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_linux_libtorch_3_7m_cpu_devtoolset7_shared-with-deps_build (1/2)

Step: "Checkout pytorch/builder repo" (full log | diagnosis details | 🔁 rerun)

fatal: reference is not a tree: cd5a9b73c3028d2496666201588111a8c8d84878 
+ sleep 2 
+ git submodule update --init --recursive 
fatal: reference is not a tree: cd5a9b73c3028d2496666201588111a8c8d84878 
Unable to checkout 'cd5a9b73c3028d2496666201588111a8c8d84878' in submodule path 'third_party/nccl/nccl' 
+ sleep 4 
+ git submodule update --init --recursive 
fatal: reference is not a tree: cd5a9b73c3028d2496666201588111a8c8d84878 
Unable to checkout 'cd5a9b73c3028d2496666201588111a8c8d84878' in submodule path 'third_party/nccl/nccl' 
+ sleep 8 
+ git submodule update --init --recursive 
fatal: reference is not a tree: cd5a9b73c3028d2496666201588111a8c8d84878 
Unable to checkout 'cd5a9b73c3028d2496666201588111a8c8d84878' in submodule path 'third_party/nccl/nccl'

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:229: error: Need type annotation for 'weights' (hint: "weights: Dict[, ] = ...") [var-annotated] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:99: error: Incompatible types in assignment (expression has type "int", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:105: error: Incompatible types in assignment (expression has type "List[Any]", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:106: error: Incompatible types in assignment (expression has type "List[Any]", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:107: error: Incompatible types in assignment (expression has type "int", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:115: error: Incompatible types in assignment (expression has type "bool", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:117: error: Incompatible types in assignment (expression has type "Dict[Any, Any]", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:159: error: Need type annotation for 'serialized_dict' (hint: "serialized_dict: Dict[<type>, <type>] = ...")  [var-annotated] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:192: error: Module has no attribute "GraphModule"  [attr-defined] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:215: error: Incompatible types in assignment (expression has type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:218: error: Incompatible types in assignment (expression has type "Union[Tuple[Any, ...], List[Any], Dict[str, Any], slice, Node, str, int, float, bool, dtype, Tensor, None]", target has type "str")  [assignment] 
Nov 09 15:09:13 torch/fx/experimental/GraphManipulation.py:229: error: Need type annotation for 'weights' (hint: "weights: Dict[<type>, <type>] = ...")  [var-annotated] 
Nov 09 15:09:13 Found 12 errors in 1 file (checked 1138 source files) 
Nov 09 15:09:13   
Nov 09 15:09:13  
Nov 09 15:09:13 ---------------------------------------------------------------------- 
Nov 09 15:09:13 Ran 4 tests in 93.716s 
Nov 09 15:09:13  
Nov 09 15:09:13 FAILED (failures=1) 
Nov 09 15:09:13  
Nov 09 15:09:13 Generating XML reports... 
Nov 09 15:09:13 Generated XML report: test-reports/dist-gloo/TEST-TestTypeHints-20201109150739.xml
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

albanD
albanD approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

facebook-github-bot
facebook-github-bot reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 9, 2020

@albanD merged this pull request in a49367e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfkasim1 @facebook-github-bot @albanD @pytorchbot