Use f-strings in torch.utils.cpp_extension#47025
Closed
malfet wants to merge 3 commits intopytorch:masterfrom
Closed
Use f-strings in torch.utils.cpp_extension#47025malfet wants to merge 3 commits intopytorch:masterfrom
malfet wants to merge 3 commits intopytorch:masterfrom
Conversation
Use iterator of type Py_ssize_t for array indexing
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
samestep
approved these changes
Oct 28, 2020
Contributor
samestep
left a comment
There was a problem hiding this comment.
lgtm 👍 is there a reason these two files are both being changed in the same PR though?
💊 CI failures summary and remediationsAs of commit 65b4612 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## master #47025 +/- ##
=======================================
Coverage 68.94% 68.94%
=======================================
Files 434 434
Lines 56189 56189
=======================================
Hits 38741 38741
Misses 17448 17448 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus two minor fixes to
torch/csrc/Module.cpp:Py_ssize_tfor array indexing inTHPModule_initNamesconst auto&