[wip] Add batched linear system of equations support to torch.gesv#4612
Closed
zou3519 wants to merge 5 commits intopytorch:masterfrom
Closed
[wip] Add batched linear system of equations support to torch.gesv#4612zou3519 wants to merge 5 commits intopytorch:masterfrom
torch.gesv#4612zou3519 wants to merge 5 commits intopytorch:masterfrom
Conversation
Collaborator
db6ee32 to
b2757fe
Compare
torch.gesvtorch.gesv
Contributor
Author
|
Closing in favor of a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3164
Picks up from #4502. I rewrote the code in ATen, which led to nice support for the following features:
A side note:
torch.gesv()on tensors is different fromtorch.gesvon Variable. On tensor, the behavior falls back toTHTensor_(gesv)because ATen doesn't support dispatching to tensors yet. When tensors/variables merge this should be fixed.Test Plan
New unit tests to test arbitrary batched dimensions and broadcasting.