Skip to content

Fix IS_SPMM_AVAILABLE macro definition#42643

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-cusparse-define
Closed

Fix IS_SPMM_AVAILABLE macro definition#42643
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/fix-cusparse-define

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Aug 5, 2020

defined is not a function, and so it can not be used in macro substitution.

This should fix CUDA-11 on Windows build issue

This should fix CUDA-11 on Windows build issue
@malfet malfet requested review from ezyang and seemethere August 5, 2020 23:36
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in 9add11f.

@dr-ci
Copy link
Copy Markdown

dr-ci bot commented Aug 6, 2020

💊 CI failures summary and remediations

As of commit 1096a4f (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 2 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants