Add a CPU Fuser (single core) by zdevito · Pull Request #3961 · pytorch/pytorch

zdevito · 2017-12-01T06:30:38Z

This adds a simple fusion backend for the CPU.

Refactors CompiledFusionFunction to have two subclasses that handle
the compilation details of each backend.
emit-compile-link-run cycle for the CPU
simple single core loop to run the operation
lift CUDA-only restrictions in the fuser, checks that fusion groups
are only on a single backend.

Perf tests need to be done to see if this is a lot slower than current CPU maps.
We need some reasonable way to do threading for parallelization (pthreads, tbb, openmp, etc.), but that can be a different commit.

pytorchbot · 2017-12-01T06:30:38Z

@zdevito, thanks for your PR! We identified @zdevito to be a potential reviewer.

ezyang

Sweeeeeeet

torch/csrc/jit/fusion_compiler.cpp

zdevito · 2017-12-01T15:01:44Z

@pytorchbot retest this please

apaszke

LGTM. I added a few minor comments, but feel free to ignore them.

torch/csrc/jit/fusion_compiler.cpp

torch/csrc/jit/fusion_compiler.h

This adds a simple fusion backend for the CPU. * Refactors CompiledFusionFunction to have two subclasses that handle the compilation details of each backend. * emit-compile-link-run cycle for the CPU * simple single core loop to run the operation * lift CUDA-only restrictions in the fuser, checks that fusion groups are only on a single backend.

Relax the amount of file syncing for cpp file.

ezyang approved these changes Dec 1, 2017

View reviewed changes

apaszke approved these changes Dec 2, 2017

View reviewed changes

zdevito force-pushed the pr/cpu_fuser branch from 2348709 to 6aca030 Compare December 2, 2017 05:54

zdevito added 3 commits December 4, 2017 10:33

Make TempFiles lifetimes shorter.

f9eb0cc

Relax the amount of file syncing for cpp file.

Fuser now locates g++.

4621e76

zdevito force-pushed the pr/cpu_fuser branch from a558c5c to 4621e76 Compare December 4, 2017 18:33

zdevito merged commit 61a582d into pytorch:master Dec 4, 2017

pbelevich mentioned this pull request Jun 13, 2020

[Reland] Include AT_PARALLEL_OPENMP/AT_PARALLEL_NATIVE/AT_PARALLEL_NATIVE_TBB to ATen/Config.h #39881

Closed

Conversation

zdevito commented Dec 1, 2017

Uh oh!

pytorchbot commented Dec 1, 2017

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

zdevito commented Dec 1, 2017

Uh oh!

apaszke left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants