[android][gradle] Gradle build offline dependencies #2#29738
Closed
IvanKobzarev wants to merge 1 commit intomasterfrom
Closed
[android][gradle] Gradle build offline dependencies #2#29738IvanKobzarev wants to merge 1 commit intomasterfrom
IvanKobzarev wants to merge 1 commit intomasterfrom
Conversation
e5d1783 to
3d0c292
Compare
ezyang
approved these changes
Nov 13, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@IvanKobzarev merged this pull request in 71aacf7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue: #29159
The issue with previous reverted PR was that after phabricator's lint error about double quotes I changed:
$GRADLE_PATH $GRADLE_PARAMS->"$GRADLE_PATH" "$GRADLE_PARAMS"which ended in error: