Skip to content

docstring only formatting changes: quantize.py, fake_quantize.py, observer.py#27415

Closed
gottbrath wants to merge 4 commits intopytorch:masterfrom
gottbrath:chris-quant-docstring-pr-master
Closed

docstring only formatting changes: quantize.py, fake_quantize.py, observer.py#27415
gottbrath wants to merge 4 commits intopytorch:masterfrom
gottbrath:chris-quant-docstring-pr-master

Conversation

@gottbrath
Copy link
Contributor

No description provided.

@gottbrath gottbrath changed the title docstring only formatting changes to quantize.py and fake_quantize.py docstring only formatting changes: quantize.py, fake_quantize.py, observer.py Oct 6, 2019
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottbrath
Copy link
Contributor Author

This fixes #26834, and helps fix #27428, and #26470, and #26469

@gottbrath
Copy link
Contributor Author

I see a notice that merging is blocked but I also see a green button that says "import to phabricator" Will try clicking.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gottbrath has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gottbrath has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gottbrath merged this pull request in a96b003.

@gottbrath gottbrath mentioned this pull request Oct 8, 2019
@gottbrath
Copy link
Contributor Author

based on Soumith's comments on #27414 there might be some merge conflicts here. Will see if I can diagnose and resolve.

@gottbrath
Copy link
Contributor Author

I think that I have revised the PR i sent Soumith for v1.3.0 so that it won't conflict with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants