Skip to content

Change keyword 'not' (unsupported in windows build) to '!'#27362

Closed
bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq:fix-not-in-win
Closed

Change keyword 'not' (unsupported in windows build) to '!'#27362
bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq:fix-not-in-win

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Oct 4, 2019

https://ci.pytorch.org/jenkins/job/caffe2-builds/job/py2-cuda9.0-cudnn7-windows-build/71076//console

00:25:49 C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\aten\src\ATen/native/cpu/IsContiguous.h(41): error C2065: 'not': undeclared identifier
00:25:49 C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\aten\src\ATen/native/cpu/IsContiguous.h(41): error C2059: syntax error: 'std::is_void<traits::result_type>::value'
00:25:49 C:\Jenkins\workspace\caffe2-builds\py2-cuda9.0-cudnn7-windows-build\aten\src\ATen/native/cpu/IsContiguous.h(41): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ifedan ifedan ifedan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: cpu CPU specific problem (e.g., perf, algorithm)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bddppq @facebook-github-bot @ifedan @pytorchbot