Prepend all PyTorch QNNPACK symbols with pytorch_ to avoid symbol collision.#26238
Closed
AshkanAliabadi wants to merge 1 commit intopytorch:masterfrom
AshkanAliabadi:qnnpack_prefix
Closed
Prepend all PyTorch QNNPACK symbols with pytorch_ to avoid symbol collision.#26238AshkanAliabadi wants to merge 1 commit intopytorch:masterfrom AshkanAliabadi:qnnpack_prefix
AshkanAliabadi wants to merge 1 commit intopytorch:masterfrom
AshkanAliabadi:qnnpack_prefix
Conversation
Contributor
|
Did we test this using unit tests? |
ljk53
approved these changes
Sep 15, 2019
Contributor
ljk53
left a comment
There was a problem hiding this comment.
Looks like these are simply adding prefix to symbols under aten/src/ATen/native/quantized/cpu/qnnpack. Stamp it as it won't affect things outside this directory.
Collaborator
|
Looks good. For testing - you probably can run objdump/nm on the resulting static library and see whether anything is left |
supriyar
approved these changes
Sep 16, 2019
Contributor
Author
|
Merged into #25844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This probably doesn't catch absolutely everything but it's a good starting point.