Manually implement is_zipfile
#25279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default implementation is lenient in that it recognizes a zipfile if the magic number appears anywhere in the archive. So if someone has the bytes `PK\x03\x04` in a tensor, it gets recognized as a zipfile. This implementation only checks the first 4 bytes of the file for the zip magic number. Fixes #25214
zou3519
requested changes
Aug 28, 2019
Contributor
zou3519
left a comment
There was a problem hiding this comment.
Needs test unless it's hard to repro the bug. However, it sounds like one just needs to serialize a tensor with the magic numbers?
ezyang
requested changes
Aug 28, 2019
Contributor
ezyang
left a comment
There was a problem hiding this comment.
As Richard said, needs test. Lint failures are real too. Also, shouldn't we be using b'' strings?
Contributor
Author
|
|
zou3519
reviewed
Aug 29, 2019
ezyang
reviewed
Aug 29, 2019
ezyang
approved these changes
Aug 29, 2019
zou3519
approved these changes
Aug 29, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default implementation is lenient in that it recognizes a zipfile if the magic number appears anywhere in the archive. So if someone has the bytes
PK\x03\x04in a tensor, it gets recognized as a zipfile. See https://bugs.python.org/issue28494This implementation only checks the first 4 bytes of the file for the zip magic number. We could also copy python/cpython#5053 fix, but that seems like overkill.
Fixes #25214
Differential Revision: D17102516