Skip to content

Update fbgemm submodule#21328

Closed
bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq:bump-fbgemm
Closed

Update fbgemm submodule#21328
bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq:bump-fbgemm

Conversation

@bddppq
Copy link
Contributor

@bddppq bddppq commented Jun 4, 2019

Fix master breakage

Jun 03 22:30:50 /var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qlinear_unpack.cpp: In member function 'at::Tensor at::native::{anonymous}::QLinearUnpackWeightInt8::operator()(at::Tensor)':
Jun 03 22:30:50 /var/lib/jenkins/workspace/aten/src/ATen/native/quantized/cpu/qlinear_unpack.cpp:37:12: error: 'class fbgemm::PackBMatrix<signed char>' has no member named 'unpack'
Jun 03 22:30:50      packB->unpack(weight_ptr_int8);
Jun 03 22:30:50  

cc @jianyuh

Fix master breakage
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bddppq bddppq requested a review from jerryzh168 June 4, 2019 04:22
Copy link
Member

@jianyuh jianyuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@facebook-github-bot
Copy link
Contributor

@bddppq merged this pull request in f251416.

@ezyang
Copy link
Contributor

ezyang commented Jun 4, 2019

This submodule land was apparently not done correctly because @yns88 reverted it in 2ee2d78

@bddppq
Copy link
Contributor Author

bddppq commented Jun 4, 2019

AFAIC 2ee2d78 is the wrong one :-) It reverted the fbgemm submodule to be not the current fbgemm master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants