[tensorboard] Some name and variable cleanup#20861
Closed
orionr wants to merge 1 commit intopytorch:masterfrom
Closed
[tensorboard] Some name and variable cleanup#20861orionr wants to merge 1 commit intopytorch:masterfrom
orionr wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
Looks good! |
ce6dd38 to
bdc9695
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of #20580 I noticed that we had some unusual variable naming in
summary.py. This cleans it up and also removes some variables that weren't being used.I'll wait until we have an
add_custom_scalarstest to land this.cc @lanpa @natalialunova