Workaround python2.7 find_module limitation / explicitly close file#20782
Closed
ailzhang wants to merge 2 commits intopytorch:masterfrom
Closed
Workaround python2.7 find_module limitation / explicitly close file#20782ailzhang wants to merge 2 commits intopytorch:masterfrom
ailzhang wants to merge 2 commits intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
It looks like the |
ezyang
reviewed
May 22, 2019
torch/hub.py
Outdated
| _remove_if_exists(extracted_repo) | ||
| # Unzip the code and rename the base folder | ||
| cached_zipfile.extractall(hub_dir) | ||
| cached_zipfile.close() |
Contributor
There was a problem hiding this comment.
Don't do this. ZipFile can be used as a context manager; that will ensure it is closed even if an exception is thrown.
ezyang
requested changes
May 22, 2019
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Looks good! But please, use a context manager :)
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
May 23, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #20781 #20757
hmm I don't know an easy way to add a test to make sure it runs against a package installed as .egg. But i tested it locally with torchvision.