Skip to content

[c10] Make basic_string_view inherit from std::basic_string_view#184152

Closed
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:c10-string-view-delegate-std
Closed

[c10] Make basic_string_view inherit from std::basic_string_view#184152
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:c10-string-view-delegate-std

Conversation

@cyyever

@cyyever cyyever commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR simplifies c10:: basic_string_view body and keeps minimal methods.

@pytorch-bot

pytorch-bot Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/184152

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 7 Pending

As of commit 633ef66 with merge base 428e02e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft May 18, 2026 03:26
@cyyever

cyyever commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "topic: not user facing"

@cyyever cyyever marked this pull request as ready for review May 18, 2026 07:22
@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label May 18, 2026
@pytorch pytorch deleted a comment from pytorch-bot Bot May 18, 2026
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label May 18, 2026
Skylion007
Skylion007 reviewed May 18, 2026
View reviewed changes
Comment thread c10/util/string_view.h Outdated
Comment thread c10/util/string_view.h
Comment thread c10/util/string_view.h
@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 19, 2026
@cyyever cyyever force-pushed the c10-string-view-delegate-std branch 5 times, most recently from a4748a9 to f1f8e9e Compare May 19, 2026 16:19
@cyyever cyyever requested a review from Skylion007 May 19, 2026 16:19
@cyyever cyyever force-pushed the c10-string-view-delegate-std branch from f1f8e9e to f233908 Compare May 19, 2026 16:22
@cyyever

cyyever commented May 20, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot rebase -b main

@pytorchmergebot

pytorchmergebot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot

pytorchmergebot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Successfully rebased c10-string-view-delegate-std onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout c10-string-view-delegate-std && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the c10-string-view-delegate-std branch from f233908 to 115b9a5 Compare May 20, 2026 02:57
@Skylion007

Skylion007 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot merge -r

@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

This PR needs to be approved by an authorized maintainer before merge.

@Skylion007

Skylion007 commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot rebase

Skylion007
Skylion007 approved these changes Jun 11, 2026
View reviewed changes

@Skylion007 Skylion007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits mostly. Otherwise good and reduces code duplication.

@pytorchmergebot

pytorchmergebot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@cyyever @pytorchmergebot
[c10] Make basic_string_view inherit from std::basic_string_view
633ef66 
Originally a port for pre-constexpr std::char_traits; C++20 fixed
that. Override only at()/substr() (CUDA no-throw) and remove_prefix/
suffix (throw on OOB where std specifies UB).
@pytorchmergebot

pytorchmergebot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Successfully rebased c10-string-view-delegate-std onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout c10-string-view-delegate-std && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the c10-string-view-delegate-std branch from 115b9a5 to 633ef66 Compare June 11, 2026 17:26
@cyyever

cyyever commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot

pytorchmergebot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @Skylion007 @pytorchbot @jbschlosser