Allow torch.arange() to return empty tensor when bounds are inconsistent with step sign#182133
Open
senekis316 wants to merge 1 commit intopytorch:mainfrom
Open
Allow torch.arange() to return empty tensor when bounds are inconsistent with step sign#182133senekis316 wants to merge 1 commit intopytorch:mainfrom
senekis316 wants to merge 1 commit intopytorch:mainfrom
Conversation
…ent with step sign Per the Array API Standard, torch.arange(start, stop, step) should return an empty tensor when stop-start and step have opposite signs, rather than raising a RuntimeError. This aligns with NumPy behavior. - Remove the inconsistent-bounds TORCH_CHECK from arange_check_bounds (RangeUtils.h) - Clamp computed size to 0 in compute_arange_size (RangeUtils.h) - Remove the corresponding check in torch/_refs/__init__.py - Update error_inputs_arange to remove now-valid inputs Fixes pytorch#70915
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/182133
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70915
Per the Array API Standard,
torch.arange(start, stop, step)should returnan empty tensor when
stop-startandstephave opposite signs, rather thanraising a RuntimeError. This aligns with NumPy's behavior.
Before: