Automatic update of fbcode/foxi to 2bcc4064c90e87b9638615c733485f07c47b7558#18070
Closed
jackm321 wants to merge 1 commit intopytorch:masterfrom
Closed
Automatic update of fbcode/foxi to 2bcc4064c90e87b9638615c733485f07c47b7558#18070jackm321 wants to merge 1 commit intopytorch:masterfrom
jackm321 wants to merge 1 commit intopytorch:masterfrom
Conversation
…7b7558 Summary: Previous import was d1f45b1a2b1585d0e9bc65e15e463db344fc3ff6 Included changes: - **[2bcc406](houseroad/foxi@2bcc406)**: Merge pull request pytorch#7 from jackm321/tracing_fixes <Jack Montgomery> - **[c39033c](houseroad/foxi@c39033c)**: Fixes for tracing events <Jack Montgomery> - **[50912cf](houseroad/foxi@50912cf)**: Merge pull request pytorch#5 from jackm321/add_trace_events <Jack Montgomery> - **[ba2fdcb](houseroad/foxi@ba2fdcb)**: Merge pull request pytorch#5 from jackm321/add_trace_events <Jack Montgomery> - **[7d42b12](houseroad/foxi@7d42b12)**: address comments <Jack Montgomery> - **[dcabd8d](houseroad/foxi@dcabd8d)**: Add trace events interface <Jack Montgomery> Differential Revision: D14483201 fbshipit-source-id: 9d76887cb3d65bc11ad3da0d798adc934d5f020e
houseroad
approved these changes
Mar 15, 2019
Member
houseroad
left a comment
There was a problem hiding this comment.
The failed test seems unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previous import was d1f45b1a2b1585d0e9bc65e15e463db344fc3ff6
Included changes:
Differential Revision: D14483201