Skip to content

[MPS] Add adaptive_avg_pool3d support for MPS#178031

Open
XwK-P wants to merge 3 commits intopytorch:mainfrom
XwK-P:mps-adaptive-avg-pool3d
Open

[MPS] Add adaptive_avg_pool3d support for MPS#178031
XwK-P wants to merge 3 commits intopytorch:mainfrom
XwK-P:mps-adaptive-avg-pool3d

Conversation

@XwK-P
Copy link
Copy Markdown

@XwK-P XwK-P commented Mar 21, 2026

Add MPS support for adaptive_avg_pool3d and its backward path.

Fixes #141287 (comment)

@XwK-P XwK-P requested review from malfet and mruberry as code owners March 21, 2026 01:11
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/178031

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2b7bf4d with merge base e9ebbd3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 21, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
Copy link
Copy Markdown
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@github-actions
Copy link
Copy Markdown
Contributor

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.


Caused by:

@malfet malfet added the ciflow/mps Run MPS tests (subset of trunk) label Mar 21, 2026
@pytorch-bot pytorch-bot bot removed the ciflow/mps Run MPS tests (subset of trunk) label Mar 21, 2026
@XwK-P
Copy link
Copy Markdown
Author

XwK-P commented Mar 21, 2026

Redundant test_adaptive_avg_pool3d_output_size_one removed. Other two kept for explicit MPS-specific coverage that OpInfo does not cover.

cc @malfet

@XwK-P XwK-P requested a review from malfet March 21, 2026 07:58
@XwK-P
Copy link
Copy Markdown
Author

XwK-P commented Mar 21, 2026

@pytorchbot label ciflow/mps

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 21, 2026

To add these label(s) (ciflow/mps) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@XwK-P
Copy link
Copy Markdown
Author

XwK-P commented Mar 21, 2026

@pytorchbot label ciflow/mps

@pytorch-bot pytorch-bot bot added the ciflow/mps Run MPS tests (subset of trunk) label Mar 21, 2026
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 23, 2026
@XwK-P
Copy link
Copy Markdown
Author

XwK-P commented Mar 30, 2026

@malfet I addressed the earlier feedback and removed the redundant test_adaptive_avg_pool3d_output_size_one test, while keeping the two MPS-specific coverage tests. CI passing as well. Could you please take another look when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) open source release notes: inductor (aoti) release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPS operator coverage tracking issue (2.6+ version)

4 participants