[MPS] Add adaptive_avg_pool3d support for MPS#178031
[MPS] Add adaptive_avg_pool3d support for MPS#178031XwK-P wants to merge 3 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/178031
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2b7bf4d with merge base e9ebbd3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
Attention! PyTorch one of the C-stable API file was changedYou MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function. Caused by: |
|
Redundant test_adaptive_avg_pool3d_output_size_one removed. Other two kept for explicit MPS-specific coverage that OpInfo does not cover. cc @malfet |
|
@pytorchbot label ciflow/mps |
|
To add these label(s) (ciflow/mps) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page). This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
@pytorchbot label ciflow/mps |
|
@malfet I addressed the earlier feedback and removed the redundant test_adaptive_avg_pool3d_output_size_one test, while keeping the two MPS-specific coverage tests. CI passing as well. Could you please take another look when you have a chance? |
Add MPS support for
adaptive_avg_pool3dand its backward path.Fixes #141287 (comment)